Defer isn't useful as we never leave the scope
authorJacob Casper <dev@jacobcasper.com>
Fri, 17 Apr 2020 18:27:25 +0000 (13:27 -0500)
committerJacob Casper <dev@jacobcasper.com>
Fri, 17 Apr 2020 18:27:25 +0000 (13:27 -0500)
backend/scrape/graph/graph.go

index d043209..3198110 100644 (file)
@@ -26,18 +26,19 @@ WHERE ID NOT IN (
                        log.Print(err)
                        continue infinite
                }
                        log.Print(err)
                        continue infinite
                }
-               defer rows.Close()
 
                var artistId string
                for rows.Next() {
                        if err := rows.Scan(&artistId); err != nil {
                                log.Print(err)
 
                var artistId string
                for rows.Next() {
                        if err := rows.Scan(&artistId); err != nil {
                                log.Print(err)
+                               rows.Close()
                                continue infinite
                        }
 
                        artists, err := env.C.GetRelatedArtists(spotify.ID(artistId))
                        if err != nil {
                                log.Print(err)
                                continue infinite
                        }
 
                        artists, err := env.C.GetRelatedArtists(spotify.ID(artistId))
                        if err != nil {
                                log.Print(err)
+                               rows.Close()
                                continue infinite
                        }
 
                                continue infinite
                        }