Code style fixes
authorLiza Carvelli <liza@carvel.li>
Fri, 13 Jun 2025 20:52:22 +0000 (22:52 +0200)
committerLiza Carvelli <liza@carvel.li>
Fri, 13 Jun 2025 20:52:22 +0000 (22:52 +0200)
47 files changed:
Questionable/.editorconfig
Questionable/Configuration.cs
Questionable/Controller/CombatController.cs
Questionable/Controller/CombatModules/ItemUseModule.cs
Questionable/Controller/CombatModules/Mount128Module.cs
Questionable/Controller/CombatModules/Mount147Module.cs
Questionable/Controller/CombatModules/RotationSolverRebornModule.cs
Questionable/Controller/GameUi/InteractionUiController.cs
Questionable/Controller/InterruptHandler.cs
Questionable/Controller/MovementController.cs
Questionable/Controller/QuestController.cs
Questionable/Controller/Steps/Common/NextQuest.cs
Questionable/Controller/Steps/Common/SendNotification.cs
Questionable/Controller/Steps/Interactions/AetherCurrent.cs
Questionable/Controller/Steps/Interactions/AethernetShard.cs
Questionable/Controller/Steps/Interactions/Dive.cs
Questionable/Controller/Steps/Interactions/EquipRecommended.cs
Questionable/Controller/Steps/Interactions/Jump.cs
Questionable/Controller/Steps/Interactions/Say.cs
Questionable/Controller/Steps/Interactions/SinglePlayerDuty.cs
Questionable/Controller/Steps/QuestCleanUp.cs
Questionable/Controller/Steps/Shared/AetheryteShortcut.cs
Questionable/Controller/Steps/Shared/ExtraConditionUtils.cs
Questionable/Controller/Steps/TaskExecutor.cs
Questionable/Data/GatheringData.cs
Questionable/Data/JournalData.cs
Questionable/External/QuestionableIpc.cs
Questionable/External/TextAdvanceIpc.cs
Questionable/Functions/AlliedSocietyQuestFunctions.cs
Questionable/Functions/GameFunctions.cs
Questionable/ServiceCollectionExtensions.cs
Questionable/Validation/Validators/SinglePlayerInstanceValidator.cs
Questionable/Windows/ConfigComponents/DebugConfigComponent.cs
Questionable/Windows/ConfigComponents/DutyConfigComponent.cs
Questionable/Windows/ConfigComponents/GeneralConfigComponent.cs
Questionable/Windows/ConfigComponents/SinglePlayerDutyConfigComponent.cs
Questionable/Windows/ConfigWindow.cs
Questionable/Windows/DebugOverlay.cs
Questionable/Windows/JournalComponents/GatheringJournalComponent.cs
Questionable/Windows/JournalComponents/QuestJournalComponent.cs
Questionable/Windows/JournalComponents/QuestJournalUtils.cs
Questionable/Windows/PriorityWindow.cs
Questionable/Windows/QuestComponents/ARealmRebornComponent.cs
Questionable/Windows/QuestComponents/ActiveQuestComponent.cs
Questionable/Windows/QuestComponents/CreationUtilsComponent.cs
Questionable/Windows/QuestSelectionWindow.cs
Questionable/Windows/QuestValidationWindow.cs

index 1eba5c1..06c844b 100644 (file)
@@ -1019,3 +1019,4 @@ csharp_style_unused_value_expression_statement_preference = discard_variable:sil
 resharper_arrange_trailing_comma_in_multiline_lists_highlighting = none
 resharper_redundant_if_else_block_highlighting = none
 resharper_convert_to_primary_constructor_highlighting = hint
+resharper_redundant_using_directive_highlighting = warning
index be772a5..fdfef8b 100644 (file)
@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using Dalamud.Configuration;
 using Dalamud.Game.Text;
index e6090e2..d892a27 100644 (file)
@@ -20,7 +20,6 @@ using Questionable.Controller.Utils;
 using Questionable.Functions;
 using Questionable.Model;
 using Questionable.Model.Questing;
-using Questionable.Model.Questing.Converter;
 
 namespace Questionable.Controller;
 
index 95dbea5..43d7296 100644 (file)
@@ -9,7 +9,6 @@ using FFXIVClientStructs.FFXIV.Client.Game.Character;
 using FFXIVClientStructs.FFXIV.Client.UI.Agent;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
-using Questionable.Functions;
 using Questionable.Model.Questing;
 
 namespace Questionable.Controller.CombatModules;
index 9f88596..cfccd24 100644 (file)
@@ -1,8 +1,5 @@
-using System;
-using System.Numerics;
-using Dalamud.Game.ClientState.Objects.Types;
+using Dalamud.Game.ClientState.Objects.Types;
 using Questionable.Functions;
-using Questionable.Model;
 using Questionable.Model.Questing;
 
 namespace Questionable.Controller.CombatModules;
index 4d8202f..57f39cd 100644 (file)
@@ -1,8 +1,5 @@
-using System;
-using System.Numerics;
-using Dalamud.Game.ClientState.Objects.Types;
+using Dalamud.Game.ClientState.Objects.Types;
 using Questionable.Functions;
-using Questionable.Model;
 using Questionable.Model.Questing;
 
 namespace Questionable.Controller.CombatModules;
index 422ae7c..73eb78a 100644 (file)
@@ -1,13 +1,10 @@
 using System;
-using System.Numerics;
 using Dalamud.Game.ClientState.Objects.Types;
 using Dalamud.Plugin;
 using Dalamud.Plugin.Ipc;
 using Dalamud.Plugin.Ipc.Exceptions;
-using Dalamud.Plugin.Services;
 using JetBrains.Annotations;
 using Microsoft.Extensions.Logging;
-using Questionable.Model;
 
 namespace Questionable.Controller.CombatModules;
 
index ef939db..a1ae9fb 100644 (file)
@@ -17,7 +17,6 @@ using LLib.GameData;
 using LLib.GameUI;
 using Lumina.Excel.Sheets;
 using Microsoft.Extensions.Logging;
-using Questionable.Controller.Steps.Interactions;
 using Questionable.Data;
 using Questionable.External;
 using Questionable.Functions;
index 49b24ab..7ac6d90 100644 (file)
@@ -1,7 +1,5 @@
 using System;
-using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
-using Dalamud.Game;
 using Dalamud.Hooking;
 using Dalamud.Plugin.Services;
 using FFXIVClientStructs.FFXIV.Client.Game;
index aa8deaa..896fbf6 100644 (file)
@@ -23,7 +23,6 @@ using Questionable.Model;
 using Questionable.Model.Common;
 using Questionable.Model.Common.Converter;
 using Questionable.Model.Questing;
-using Questionable.Model.Questing.Converter;
 
 namespace Questionable.Controller;
 
index 61191bb..f8815df 100644 (file)
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
-using System.Text;
 using Dalamud.Game.ClientState.Conditions;
 using Dalamud.Game.ClientState.Keys;
 using Dalamud.Game.Gui.Toast;
index 7f8cff1..adbf538 100644 (file)
@@ -1,6 +1,4 @@
-using System.Linq;
-using Microsoft.Extensions.Logging;
-using Questionable.Data;
+using Microsoft.Extensions.Logging;
 using Questionable.Functions;
 using Questionable.Model;
 using Questionable.Model.Questing;
index dda0384..320d793 100644 (file)
@@ -1,5 +1,4 @@
-using System.Collections.Generic;
-using Dalamud.Game.Text;
+using Dalamud.Game.Text;
 using Dalamud.Game.Text.SeStringHandling;
 using Dalamud.Plugin.Services;
 using Questionable.Data;
index 7c1f633..3f75144 100644 (file)
@@ -1,6 +1,5 @@
 using System;
 using Dalamud.Plugin.Services;
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Questionable.Data;
 using Questionable.Functions;
index db2c521..c7cbcfe 100644 (file)
@@ -1,5 +1,4 @@
 using System;
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Questionable.Functions;
 using Questionable.Model;
index eea9cd8..58db178 100644 (file)
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Runtime.InteropServices;
 using Dalamud.Game.ClientState.Conditions;
@@ -8,7 +7,6 @@ using Dalamud.Plugin.Services;
 using FFXIVClientStructs.FFXIV.Client.Graphics.Kernel;
 using FFXIVClientStructs.FFXIV.Client.System.String;
 using FFXIVClientStructs.FFXIV.Client.UI;
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Questionable.Controller.Steps.Common;
 using Questionable.Model;
index a71cc3b..4fd25bb 100644 (file)
@@ -3,7 +3,6 @@ using Dalamud.Game.ClientState.Conditions;
 using Dalamud.Plugin.Services;
 using FFXIVClientStructs.FFXIV.Client.Game;
 using FFXIVClientStructs.FFXIV.Client.UI.Misc;
-using Microsoft.Extensions.DependencyInjection;
 using Questionable.Model;
 using Questionable.Model.Questing;
 
index 3238405..229c445 100644 (file)
@@ -2,9 +2,7 @@
 using Dalamud.Game.ClientState.Conditions;
 using Dalamud.Plugin.Services;
 using FFXIVClientStructs.FFXIV.Client.Game;
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
-using Questionable.Controller.Steps.Common;
 using Questionable.Model;
 using Questionable.Model.Questing;
 
index ffb5621..9cf5253 100644 (file)
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using Microsoft.Extensions.DependencyInjection;
 using Questionable.Controller.Steps.Common;
 using Questionable.Functions;
 using Questionable.Model;
index 770e5c8..84f3267 100644 (file)
@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Linq;
-using System.Threading.Tasks;
 using Dalamud.Plugin.Services;
 using FFXIVClientStructs.FFXIV.Component.GUI;
 using LLib.GameUI;
@@ -9,7 +8,6 @@ using Questionable.Controller.Steps.Shared;
 using Questionable.Data;
 using Questionable.Functions;
 using Questionable.Model;
-using Questionable.Model.Common;
 using Questionable.Model.Questing;
 
 namespace Questionable.Controller.Steps;
index 37561b3..0cd0a06 100644 (file)
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.IO;
 using System.Linq;
 using System.Numerics;
 using Dalamud.Game.ClientState.Conditions;
index 2f9e039..50246d4 100644 (file)
@@ -1,9 +1,6 @@
 using System;
 using System.Numerics;
 using Dalamud.Plugin.Services;
-using FFXIVClientStructs.FFXIV.Client.Game;
-using FFXIVClientStructs.FFXIV.Client.Game.UI;
-using Microsoft.Extensions.Logging;
 using Questionable.Model.Questing;
 
 namespace Questionable.Controller.Steps.Shared;
index 0d0f2a5..2acc351 100644 (file)
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using Questionable.Model;
 
 namespace Questionable.Controller.Steps;
 
index 105911d..f44a943 100644 (file)
@@ -2,7 +2,6 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Dalamud.Plugin.Services;
-using LLib.GameData;
 using Lumina.Excel.Sheets;
 using Questionable.Model.Gathering;
 
index 80f7560..6b44243 100644 (file)
@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using Dalamud.Plugin.Services;
-using FFXIVClientStructs.FFXIV.Client.Game.Fate;
 using Lumina.Excel.Sheets;
 using Questionable.Model;
 using Questionable.Model.Questing;
index b59ae3f..0d32c89 100644 (file)
@@ -2,13 +2,11 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Numerics;
-using Dalamud.Game.ClientState.Objects;
 using Dalamud.Plugin;
 using Dalamud.Plugin.Ipc;
 using JetBrains.Annotations;
 using Questionable.Controller;
 using Questionable.Functions;
-using Questionable.Model;
 using Questionable.Model.Questing;
 using Questionable.Windows;
 using Questionable.Windows.QuestComponents;
index f840cc1..b7f2d14 100644 (file)
@@ -1,10 +1,7 @@
 using Dalamud.Plugin;
 using Dalamud.Plugin.Ipc;
 using Dalamud.Plugin.Services;
-using FFXIVClientStructs.FFXIV.Client.Game;
 using Questionable.Controller;
-using Questionable.Data;
-using Questionable.Model.Common;
 using System;
 using System.Diagnostics.CodeAnalysis;
 
index 6960da5..3588b9b 100644 (file)
@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Runtime.InteropServices;
 using FFXIVClientStructs.FFXIV.Client.Game;
 using Microsoft.Extensions.Logging;
 using Questionable.Data;
index e9b4ac7..c502321 100644 (file)
@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Linq;
 using System.Numerics;
index 2b17a83..7b4b629 100644 (file)
@@ -1,5 +1,4 @@
-using Dalamud.Plugin.Services;
-using JetBrains.Annotations;
+using JetBrains.Annotations;
 using Microsoft.Extensions.DependencyInjection;
 using Questionable.Controller.Steps;
 
index 41ded00..6a6ddf2 100644 (file)
@@ -1,6 +1,5 @@
 using Dalamud.Interface.Colors;
 using Dalamud.Interface.Components;
-using Dalamud.Interface.Utility;
 using Dalamud.Interface.Utility.Raii;
 using Dalamud.Plugin;
 using ImGuiNET;
index 35f79cf..31e077f 100644 (file)
@@ -4,7 +4,6 @@ using System.Globalization;
 using System.Linq;
 using System.Numerics;
 using System.Text;
-using Dalamud.Game.Text;
 using Dalamud.Interface;
 using Dalamud.Interface.Colors;
 using Dalamud.Interface.Components;
index 243a417..c63798e 100644 (file)
@@ -1,14 +1,12 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using Dalamud.Interface.Colors;
 using Dalamud.Interface.Utility.Raii;
 using Dalamud.Plugin;
 using Dalamud.Plugin.Services;
 using ImGuiNET;
 using LLib.GameData;
 using Lumina.Excel.Sheets;
-using Questionable.Controller;
 using Questionable.Data;
 using GrandCompany = FFXIVClientStructs.FFXIV.Client.UI.Agent.GrandCompany;
 
index ff756a2..369e254 100644 (file)
@@ -4,7 +4,6 @@ using System.Collections.Immutable;
 using System.Collections.ObjectModel;
 using System.Linq;
 using System.Numerics;
-using Dalamud.Game.Text;
 using Dalamud.Interface;
 using Dalamud.Interface.Colors;
 using Dalamud.Interface.Components;
@@ -16,7 +15,6 @@ using LLib.GameData;
 using Lumina.Excel.Sheets;
 using Microsoft.Extensions.Logging;
 using Questionable.Controller;
-using Questionable.Controller.Steps.Interactions;
 using Questionable.Data;
 using Questionable.Model;
 using Questionable.Model.Common;
index 352e18c..0f32f74 100644 (file)
@@ -2,7 +2,6 @@
 using Dalamud.Plugin;
 using ImGuiNET;
 using LLib.ImGui;
-using Questionable.Controller.Steps.Interactions;
 using Questionable.Windows.ConfigComponents;
 
 namespace Questionable.Windows;
index 0d69588..6842d2b 100644 (file)
@@ -1,5 +1,4 @@
-using System.Diagnostics;
-using System.Diagnostics.CodeAnalysis;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
 using System.Numerics;
index b14d065..1104d9e 100644 (file)
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Collections.Immutable;
 using System.Globalization;
 using System.Linq;
 using Dalamud.Interface;
index 0e45b5e..de5d3e2 100644 (file)
@@ -2,7 +2,6 @@
 using Dalamud.Interface.Colors;
 using Dalamud.Interface.Utility.Raii;
 using Dalamud.Plugin;
-using Dalamud.Plugin.Services;
 using ImGuiNET;
 using Questionable.Controller;
 using Questionable.Data;
index bb921e5..613a944 100644 (file)
@@ -6,8 +6,6 @@ using Questionable.Controller;
 using Questionable.Functions;
 using Questionable.Model;
 using Questionable.Model.Questing;
-using System;
-using Dalamud.Interface.Colors;
 
 namespace Questionable.Windows.JournalComponents;
 
index 72386e0..e80b2a7 100644 (file)
@@ -1,5 +1,4 @@
 using System;
-using System.Buffers.Text;
 using System.Collections.Generic;
 using System.Linq;
 using System.Numerics;
index 9bd1f41..e4f8b8b 100644 (file)
@@ -1,7 +1,6 @@
 using System.Linq;
 using Dalamud.Interface;
 using Dalamud.Interface.Colors;
-using Dalamud.Interface.Style;
 using Dalamud.Interface.Utility.Raii;
 using FFXIVClientStructs.FFXIV.Client.Game.UI;
 using FFXIVClientStructs.FFXIV.Common.Math;
index 17580b5..e88177e 100644 (file)
@@ -8,7 +8,6 @@ using Dalamud.Interface;
 using Dalamud.Interface.Colors;
 using Dalamud.Interface.Components;
 using Dalamud.Interface.Utility.Raii;
-using Dalamud.Plugin;
 using Dalamud.Plugin.Services;
 using ImGuiNET;
 using Questionable.Controller;
index 4bb68c1..7417481 100644 (file)
@@ -10,12 +10,8 @@ using Dalamud.Interface;
 using Dalamud.Interface.Colors;
 using Dalamud.Interface.Components;
 using Dalamud.Plugin.Services;
-using FFXIVClientStructs.FFXIV.Client.Game;
-using FFXIVClientStructs.FFXIV.Client.Game.Character;
 using FFXIVClientStructs.FFXIV.Client.Game.Control;
-using FFXIVClientStructs.FFXIV.Client.Game.Event;
 using FFXIVClientStructs.FFXIV.Client.Game.Object;
-using FFXIVClientStructs.FFXIV.Client.Game.UI;
 using ImGuiNET;
 using Microsoft.Extensions.Logging;
 using Questionable.Controller;
@@ -23,7 +19,6 @@ using Questionable.Data;
 using Questionable.Functions;
 using Questionable.Model;
 using Questionable.Model.Common;
-using Questionable.Model.Questing;
 using ObjectKind = Dalamud.Game.ClientState.Objects.Enums.ObjectKind;
 
 namespace Questionable.Windows.QuestComponents;
index 7821856..59aceb9 100644 (file)
@@ -1,6 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Globalization;
+using System.Collections.Generic;
 using System.Linq;
 using System.Numerics;
 using Dalamud.Game.ClientState.Objects.Types;
index e8a29f5..c92fb45 100644 (file)
@@ -1,14 +1,12 @@
 using System.Globalization;
 using Dalamud.Interface;
 using Dalamud.Interface.Colors;
-using Dalamud.Interface.Components;
 using Dalamud.Interface.Utility.Raii;
 using Dalamud.Plugin;
 using FFXIVClientStructs.FFXIV.Common.Math;
 using ImGuiNET;
 using LLib.ImGui;
 using Questionable.Data;
-using Questionable.Model;
 using Questionable.Validation;
 
 namespace Questionable.Windows;