Version bump
authorLiza Carvelli <liza@carvel.li>
Mon, 3 Mar 2025 22:20:53 +0000 (23:20 +0100)
committerLiza Carvelli <liza@carvel.li>
Mon, 3 Mar 2025 22:24:25 +0000 (23:24 +0100)
Directory.Build.targets
Questionable.IpcTest/IpcTestPlugin.cs
Questionable/External/QuestionableIpc.cs

index 0ef99fba614cf8c19fb98f4749c19422e83ac877..b07966eae039a66fc4f63c2fe743342ac174fdb6 100644 (file)
@@ -1,5 +1,5 @@
 <Project>
     <PropertyGroup Condition="$(MSBuildProjectName) != 'GatheringPathRenderer'">
-        <Version>4.22</Version>
+        <Version>4.23</Version>
     </PropertyGroup>
 </Project>
index 5d63aa1e21ed4b961ae1f7668f5dd7e8b1a7de5a..afa682cbc26f597e0ddf5c0c37f9c01bddbd27b7 100644 (file)
@@ -1,4 +1,5 @@
-using System.Globalization;
+using System.Diagnostics.CodeAnalysis;
+using System.Globalization;
 using System.Numerics;
 using Dalamud.Game.Command;
 using Dalamud.Game.Text.SeStringHandling;
@@ -50,6 +51,8 @@ public sealed class IpcTestPlugin : IDalamudPlugin
         _commandManager.RemoveHandler("/qipc");
     }
 
+    [SuppressMessage("ReSharper", "ClassNeverInstantiated.Local")]
+    [SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Local")]
     private sealed class IpcStepData
     {
         public required string InteractionType { get; set; }
index f1095f1edaf1c5733a539a75d672b3ea84fdfd5d..417cea0ee6745e5e2e1dde1866f4888678224d61 100644 (file)
@@ -7,6 +7,7 @@ using Dalamud.Plugin.Ipc;
 using JetBrains.Annotations;
 using Questionable.Controller;
 using Questionable.Functions;
+using Questionable.Model;
 using Questionable.Model.Questing;
 using Questionable.Windows.QuestComponents;
 
@@ -115,7 +116,7 @@ internal sealed class QuestionableIpc : IDisposable
     private bool IsQuestLocked(string questId)
     {
         if (ElementId.TryFromString(questId, out var elementId) && elementId != null &&
-            _questRegistry.TryGetQuest(elementId, out var quest))
+            _questRegistry.TryGetQuest(elementId, out _))
         {
             return _questFunctions.IsQuestLocked(elementId);
         }
@@ -124,6 +125,7 @@ internal sealed class QuestionableIpc : IDisposable
 
     public void Dispose()
     {
+        _isQuestLocked.UnregisterFunc();
         _startSingleQuest.UnregisterFunc();
         _startQuest.UnregisterFunc();
         _getCurrentlyActiveEventQuests.UnregisterFunc();